Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/alert #517

Merged
merged 34 commits into from
Aug 19, 2024
Merged

Feature/alert #517

merged 34 commits into from
Aug 19, 2024

Conversation

AdhamAH
Copy link
Member

@AdhamAH AdhamAH commented Aug 6, 2024

closes #472

@Robbert Ik weet niet als deze manier is goed. Maar ik heb de logic voor tekst, kleuren en iconen weg uit storybook gehaald en bij de components-react package gezetten

Screenshot from 2024-08-06 14-27-30

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rijkshuisstijl-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 9:22am
rijkshuisstijl-community-templates ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 9:22am
rvs-rivm-nl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 9:22am

@AdhamAH AdhamAH mentioned this pull request Aug 7, 2024
# Conflicts:
#	proprietary/design-tokens/figma/figma.tokens.json
packages/components-react/src/Alert.tsx Outdated Show resolved Hide resolved
packages/components-react/src/Alert.tsx Outdated Show resolved Hide resolved
packages/components-react/src/Alert.tsx Outdated Show resolved Hide resolved
@AdhamAH AdhamAH dismissed MeesD94’s stale review August 19, 2024 09:20

The changes he asked for was answered

@AdhamAH AdhamAH merged commit 88a49e6 into main Aug 19, 2024
9 of 10 checks passed
@AdhamAH AdhamAH deleted the feature/alert branch August 19, 2024 09:20
MeesD94 pushed a commit that referenced this pull request Aug 22, 2024
closes #472 
Alert Component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert
4 participants